alamb commented on code in PR #18468:
URL: https://github.com/apache/datafusion/pull/18468#discussion_r2494672670
##########
datafusion/common/src/column.rs:
##########
@@ -382,6 +382,7 @@ mod tests {
use arrow::datatypes::{DataType, SchemaBuilder};
use std::sync::Arc;
+ #[allow(clippy::needless_pass_by_value)]
Review Comment:
I personally prefer using
```suggestion
#[expect(clippy::needless_pass_by_value)]
```
Which will error if the lint is no longer needed
`allow` will sit there silently even when the the lint is fixed
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -4648,9 +4648,9 @@ impl fmt::Display for ScalarValue {
}
None => write!(f, "NULL")?,
},
- ScalarValue::List(arr) => fmt_list(arr.to_owned() as ArrayRef, f)?,
- ScalarValue::LargeList(arr) => fmt_list(arr.to_owned() as
ArrayRef, f)?,
- ScalarValue::FixedSizeList(arr) => fmt_list(arr.to_owned() as
ArrayRef, f)?,
+ ScalarValue::List(arr) => fmt_list(arr.as_ref(), f)?,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
