adriangb commented on issue #17171: URL: https://github.com/apache/datafusion/issues/17171#issuecomment-3491902749
> I think the `CASE` structure is much better than OR'ing bounds from all partitions. However, it might be a good idea to document the new `CASE` `PhysicalExpr` structure for dynamic filters, as this could be a breaking change if users are already expecting `DynamicFilterPhysicalExpr` to have a specific structure. Sure yeah we can document it, but I also think consumers should at least be graceful in handling the contents of the dynamic filters (i.e. fail gracefully if it's unknown) and we never really promise any particular structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
