andygrove commented on code in PR #2695:
URL: https://github.com/apache/datafusion-comet/pull/2695#discussion_r2495879697
##########
spark/src/main/scala/org/apache/comet/testing/FuzzDataGenerator.scala:
##########
@@ -168,6 +168,7 @@ object FuzzDataGenerator {
case 4 => Float.MaxValue
case 5 => 0.0f
case 6 if options.generateNegativeZero => -0.0f
+ case 7 => Float.NaN
Review Comment:
It would probably be best to make this optional by adding a config option
similar to `generateNegativeZero`.
```suggestion
case 7 if options.generateNan => Float.NaN
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
