Jefffrey commented on PR #18510:
URL: https://github.com/apache/datafusion/pull/18510#issuecomment-3496675078
> @Jefffrey Yes, I’ve tested it locally all builds, tests, and Clippy checks
pass successfully.
I checked out your PR locally and ran cargo clippy and I immediately get an
error:
```sh
error: error reading Clippy's configuration file: unknown field `package`,
expected one of
absolute-paths-allowed-crates allowed-scripts
enum-variant-size-threshold
single-char-binding-names-threshold
absolute-paths-max-segments allowed-wildcard-imports
excessive-nesting-threshold
source-item-ordering
accept-comment-above-attributes
arithmetic-side-effects-allowed future-size-threshold
stack-size-threshold
accept-comment-above-statement
arithmetic-side-effects-allowed-binary ignore-interior-mutability
standard-macro-braces
allow-comparison-to-zero
arithmetic-side-effects-allowed-unary large-error-threshold
struct-field-name-threshold
allow-dbg-in-tests array-size-threshold
lint-commented-code
suppress-restriction-lint-in-const
allow-exact-repetitions avoid-breaking-exported-api
literal-representation-threshold third-party
allow-expect-in-consts await-holding-invalid-types
matches-for-let-else
too-large-for-stack
allow-expect-in-tests cargo-ignore-publish
max-fn-params-bools
too-many-arguments-threshold
allow-indexing-slicing-in-tests
check-incompatible-msrv-in-tests max-include-file-size
too-many-lines-threshold
allow-mixed-uninlined-format-args
check-inconsistent-struct-field-initializers max-struct-bools
trait-assoc-item-kinds-order
allow-one-hash-in-raw-strings check-private-items
max-suggested-slice-pattern-length
trivial-copy-size-limit
allow-panic-in-tests
cognitive-complexity-threshold max-trait-bounds
type-complexity-threshold
allow-print-in-tests
const-literal-digits-threshold min-ident-chars-threshold
unnecessary-box-size
allow-private-module-inception disallowed-macros
missing-docs-allow-unused
unreadable-literal-lint-fractions
allow-renamed-params-for disallowed-methods
missing-docs-in-crate-items
upper-case-acronyms-aggressive
allow-unwrap-in-consts disallowed-names
module-item-order-groupings
vec-box-size-threshold
allow-unwrap-in-tests disallowed-types
module-items-ordered-within-groupings
verbose-bit-mask-threshold
allow-useless-vec-in-tests doc-valid-idents
msrv
warn-on-all-wildcard-imports
allowed-dotfiles
enable-raw-pointer-heuristic-for-send pass-by-value-size-limit
warn-unsafe-macro-metavars-in-private-macros
allowed-duplicate-crates enforce-iter-loop-reborrow
pub-underscore-fields-behavior
allowed-idents-below-min-chars enforced-import-renames
semicolon-inside-block-ignore-singleline
allowed-prefixes enum-variant-name-threshold
semicolon-outside-block-ignore-multiline
--> /Users/jeffrey/Code/datafusion/clippy.toml:1:2
|
1 | [package.metadata.clippy]
| ^^^^^^^
error: could not compile `datafusion-doc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `datafusion-doc` (lib) due to 1 previous error
error: could not compile `datafusion-common-runtime` (lib) due to 1 previous
error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
