Jefffrey opened a new pull request, #18519:
URL: https://github.com/apache/datafusion/pull/18519
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #14763 and #14760
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Current `log()` signature has some drawbacks:
https://github.com/apache/datafusion/blob/a5eb9121ccf802dda547897155403b08a4fbf774/datafusion/functions/src/math/log.rs#L78-L105
- A bit nasty to look at: mixes numeric with exact float/int with exact
decimal (of exact precision and scale)
- Can't accommodate arbitrary decimals of any precision/scale (this is true
for other functions too)
Aim of this PR is to refactor it to use the coercion API, uplifting the API
where necessary to make this possible. This simplifies the signature in code,
whilst not losing flexibility.
Also other minor refactors are included to log.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
New `TypeSignatureClass` variants: Float, Decimal & Numeric
Refactor `log()` signature to be more in line with it's supported
implementations.
Fix issue in `log()` where `ColumnarValue::Scalar`s were being lost as
`ColumnarValue::Array`s for the base.
Support null propagation in `simplify()` for `log()`.
Fix issue with `calculate_binary_math` where it wasn't casting scalars.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
TODO
- Need to add tests for float16, decimal32, decimal64
- Need to add test for null propagation (ensure use array input to avoid
function inlining)
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
