martin-g commented on code in PR #18519: URL: https://github.com/apache/datafusion/pull/18519#discussion_r2503168316
########## datafusion/common/src/scalar/mod.rs: ########## @@ -4563,6 +4563,7 @@ impl_try_from!(UInt8, u8); impl_try_from!(UInt16, u16); impl_try_from!(UInt32, u32); impl_try_from!(UInt64, u64); +impl_try_from!(Float16, f16); Review Comment: Since you add this here - should there be also `impl_scalar!(f16, Float16);` at https://github.com/Jefffrey/datafusion/blob/bfb9e92ec0235e80c29e1005a379db6d5f3475d3/datafusion/common/src/scalar/mod.rs#L4408 ? ########## datafusion/expr-common/src/signature.rs: ########## @@ -378,6 +379,9 @@ impl TypeSignatureClass { TypeSignatureClass::Binary => { vec![DataType::Binary] } + TypeSignatureClass::Decimal => vec![Decimal128Type::DEFAULT_TYPE], + TypeSignatureClass::Float => vec![DataType::Float64], + TypeSignatureClass::Numeric => vec![DataType::Float64], Review Comment: ```suggestion TypeSignatureClass::Numeric => vec![DataType::Int64, DataType::Float64], ``` to show the difference between TypeSignatureClass::Float and TypeSignatureClass::Numeric -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
