andygrove commented on PR #2704:
URL:
https://github.com/apache/datafusion-comet/pull/2704#issuecomment-3498282365
> Thanks @andygrove
>
> I would also add supported signatures, for instance most recent Concat
>
> ```
> // Carry out the native execution for concat(string*)
> // falling back to Spark for other input types
> override def getSupportLevel(expr: Concat): SupportLevel = {
> if (expr.children.forall(_.dataType == DataTypes.StringType)) {
> Compatible()
> } else {
> Incompatible(Some(unsupportedReason))
> }
> }
> }
> ```
Thanks, I added a section on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
