parthchandra commented on PR #2722: URL: https://github.com/apache/datafusion-comet/pull/2722#issuecomment-3500124845
> > Approved, but did we really need this? The existing approach is also consistent with how Spark does it. > > It's a lot of work to manually keep the documentation in sync with the code for things like this, and it is easy to forget to update the docs when making code changes. I'd prefer it to be automated so that the documentation always reflects the current code. > > The Spark documentation is a good example of this. There is a section documenting the configs that can be overridden by environment variables, but it is missing `SPARK_ANSI_SQL_MODE`, for example. Makes sense. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
