andygrove opened a new issue, #2730:
URL: https://github.com/apache/datafusion-comet/issues/2730

   ### What is the problem the feature request solves?
   
   This code pattern worries me. We should fall back to Spark if we do not know 
the timezone.
   
   ```
   spark/src/main/spark-3.5/org/apache/comet/shims/CometExprShim.scala:         
       .setTimezone(timeZoneId.getOrElse("UTC"))
   spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:         
       .setTimezone(timeZoneId.getOrElse("UTC"))
   spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:        
castBuilder.setTimezone(timeZoneId.getOrElse("UTC"))
   spark/src/main/scala/org/apache/comet/serde/structs.scala:              
.setTimezone(expr.timeZoneId.getOrElse("UTC"))
   spark/src/main/scala/org/apache/comet/serde/datetime.scala:      val 
timeZone = expr.timeZoneId.getOrElse("UTC")
   spark/src/main/scala/org/apache/comet/serde/datetime.scala:      val 
timeZone = expr.timeZoneId.getOrElse("UTC")
   spark/src/main/scala/org/apache/comet/serde/datetime.scala:      val 
timeZone = expr.timeZoneId.getOrElse("UTC")
   spark/src/main/scala/org/apache/comet/serde/datetime.scala:      val 
timeZone = expr.timeZoneId.getOrElse("UTC")
   ```
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to