corasaurus-hex commented on code in PR #18557:
URL: https://github.com/apache/datafusion/pull/18557#discussion_r2507366558
##########
datafusion/physical-expr/src/expressions/literal.rs:
##########
@@ -137,6 +137,7 @@ impl PhysicalExpr for Literal {
}
/// Create a literal expression
+#[allow(clippy::needless_pass_by_value)]
Review Comment:
I wasn't sure about this one. Changing this to be `&T` produced 284 errors
spread across the following files:
```
1 error(s) datafusion/physical-expr/src/planner.rs
2 error(s) datafusion/physical-expr/src/expressions/literal.rs
3 error(s) datafusion/physical-expr/src/simplifier/mod.rs
4 error(s) datafusion/physical-expr/src/utils/mod.rs
5 error(s) datafusion/physical-expr/src/equivalence/class.rs
6 error(s) datafusion/physical-expr/src/expressions/dynamic_filters.rs
18 error(s) datafusion/physical-expr/src/simplifier/unwrap_cast.rs
22 error(s) datafusion/physical-expr/src/expressions/binary.rs
62 error(s) datafusion/physical-expr/src/expressions/in_list.rs
79 error(s) datafusion/physical-expr/src/expressions/case.rs
82 error(s) datafusion/physical-expr/src/expressions/in_list.rs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
