andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2507372825
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -416,15 +416,15 @@ abstract class ParquetReadSuite extends CometTestBase {
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
Actually I think if the test suite is mean to examine the behaviour when
`Byte` or `Short` being passed, then we should keep it as it is.
I have reverted some `.toInt` on test suites for this purpose and add a
suppression annotation instead.
@comphead @EmilyMatt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
