adriangb commented on code in PR #18449:
URL: https://github.com/apache/datafusion/pull/18449#discussion_r2507645247
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -231,56 +190,26 @@ fn evaluate_list(
ScalarValue::iter_to_array(scalars)
}
-fn try_cast_static_filter_to_set(
+/// Try to evaluate a list of expressions as constants.
+///
+/// Returns an ArrayRef if all expressions are constants (can be evaluated on
an
+/// empty RecordBatch), otherwise returns an error. This is used to detect when
+/// a list contains only literals, casts of literals, or other constant
expressions.
+fn try_evaluate_constant_list(
list: &[Arc<dyn PhysicalExpr>],
schema: &Schema,
-) -> Result<Arc<dyn Set>> {
+) -> Result<ArrayRef> {
let batch = RecordBatch::new_empty(Arc::new(schema.clone()));
- make_set(evaluate_list(list, &batch)?.as_ref())
+ evaluate_list(list, &batch)
}
-/// Custom equality check function which is used with [`ArrayHashSet`] for
existence check.
-trait IsEqual: HashValue {
- fn is_equal(&self, other: &Self) -> bool;
-}
-
-impl<T: IsEqual + ?Sized> IsEqual for &T {
- fn is_equal(&self, other: &Self) -> bool {
- T::is_equal(self, other)
- }
-}
Review Comment:
We get rid of these custom equality / hash traits
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -177,36 +165,7 @@ where
None => (0..array.len()).for_each(insert_value),
}
- ArrayHashSet { state, map }
-}
-
-/// Creates a `Box<dyn Set>` for the given list of `IN` expressions and `batch`
-fn make_set(array: &dyn Array) -> Result<Arc<dyn Set>> {
- Ok(downcast_primitive_array! {
- array => Arc::new(ArraySet::new(array, make_hash_set(array))),
- DataType::Boolean => {
- let array = as_boolean_array(array)?;
- Arc::new(ArraySet::new(array, make_hash_set(array)))
- },
Review Comment:
We get rid of this type matching logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
