adriangb commented on code in PR #18559:
URL: https://github.com/apache/datafusion/pull/18559#discussion_r2507651485
##########
datafusion/datasource-arrow/src/source.rs:
##########
@@ -259,3 +406,373 @@ impl FileOpener for ArrowOpener {
}))
}
}
+
+/// `FileSource` wrapper for both Arrow IPC file and stream formats
+#[derive(Clone)]
+pub struct ArrowSource {
+ pub inner: Arc<dyn FileSource>,
+}
+
+impl Default for ArrowSource {
+ fn default() -> Self {
+ Self::default_file_source()
+ }
+}
Review Comment:
Makes sense, sorry for all of the work you've had to go through, but it's
all for a better outcome in the end! I will try to review this tomorrow but I
have a flight so no promises. For what it's worth though I don't think this is
likely to be rushed into the 51 release since it's mostly adding a feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
