Dandandan commented on code in PR #18540:
URL: https://github.com/apache/datafusion/pull/18540#discussion_r2508272309
##########
datafusion/physical-optimizer/src/coalesce_batches.rs:
##########
@@ -72,11 +72,26 @@ impl PhysicalOptimizerRule for CoalesceBatches {
)
})
.unwrap_or(false);
+
if wrap_in_coalesce {
Ok(Transformed::yes(Arc::new(CoalesceBatchesExec::new(
plan,
target_batch_size,
))))
+ } else if let Some(async_exec) =
plan_any.downcast_ref::<AsyncFuncExec>() {
Review Comment:
Could we add it to the expression for `wrap_in_coalesce` before? E.g.
`|| plan_any
.downcast_ref::<AsyncFuncExec>()
.map(|f| ...
` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
