Omega359 commented on code in PR #18599:
URL: https://github.com/apache/datafusion/pull/18599#discussion_r2512378489
##########
datafusion/core/benches/sql_planner.rs:
##########
@@ -155,18 +159,30 @@ fn benchmark_with_param_values_many_columns(
/// 0,100...9900
/// 0,200...19800
/// 0,300...29700
-fn register_union_order_table(ctx: &SessionContext, num_columns: usize,
num_rows: usize) {
- // ("c0", [0, 0, ...])
- // ("c1": [100, 200, ...])
- // etc
- let iter = (0..num_columns).map(|i| i as u64).map(|i| {
- let array: ArrayRef =
Arc::new(arrow::array::UInt64Array::from_iter_values(
- (0..num_rows)
- .map(|j| j as u64 * 100 + i)
- .collect::<Vec<_>>(),
- ));
+fn register_union_order_table_generic<T>(
+ ctx: &SessionContext,
+ num_columns: usize,
+ num_rows: usize,
+) where
+ T: ArrowPrimitiveType,
+ T::Native: ArrowNativeTypeOp + NumCast,
+{
+ let iter = (0..num_columns).map(|i| {
+ let array_data: Vec<T::Native> = (0..num_rows)
+ .map(|j| {
+ let value = (j as u64) * 100 + (i as u64);
+ <T::Native as NumCast>::from(value).unwrap_or_else(|| {
Review Comment:
This is neat, first I've seen NumCast before. I'll have to remember this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
