alamb commented on PR #18457: URL: https://github.com/apache/datafusion/pull/18457#issuecomment-3516587864
> > @2010YOUY01 I'm fine with any name, but technically all the arrow sources in here would be `ArrowIPC*`, both file and stream. Since these are internal to the crate right now can we decide on a name in another PR or in another venue? **Or is there a mechanism for making a decisions around something like this?** This would be the third name change, including my own change, in this PR, and I'd rather get consensus somehow so I can make one final change (if needed) > > There are no formal naming rules, but my approach is to choose names that make their purpose as clear as possible. Using `Stream` here might be ambiguous due to other system concepts, so I’d prefer using a more explicit name like `IPCStream`. > > This is just a minor point, though — we can proceed with either option. We can also potentially rename the structures as a follow on PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
