alamb commented on PR #18449: URL: https://github.com/apache/datafusion/pull/18449#issuecomment-3517561626
I don't know what is going on on the benchmarks 🤔 I ran this on my laptop: ```shell gh pr checkout https://github.com/apache/datafusion/pull/18449 && git log -1 --oneline && cargo bench --bench in_list -- --save-baseline in_list && git checkout `git merge-base apache/main head` && git log -1 --oneline && cargo bench --bench in_list -- --save-baseline before ``` Then critcmp reports: ``` group before in_list ----- ------ ------- in_list_f32 (1024, 0) IN (1, 0) 1.18 2.7±0.06µs ? ?/sec 1.00 2.3±0.02µs ? ?/sec in_list_f32 (1024, 0) IN (10, 0) 1.14 2.7±0.04µs ? ?/sec 1.00 2.3±0.08µs ? ?/sec in_list_f32 (1024, 0) IN (100, 0) 1.16 2.7±0.04µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_f32 (1024, 0) IN (3, 0) 1.17 2.7±0.06µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_f32 (1024, 0.2) IN (1, 0) 1.08 3.3±0.06µs ? ?/sec 1.00 3.1±0.05µs ? ?/sec in_list_f32 (1024, 0.2) IN (10, 0) 1.06 3.3±0.08µs ? ?/sec 1.00 3.1±0.05µs ? ?/sec in_list_f32 (1024, 0.2) IN (100, 0) 1.03 3.4±0.05µs ? ?/sec 1.00 3.3±0.06µs ? ?/sec in_list_f32 (1024, 0.2) IN (3, 0) 1.07 3.3±0.08µs ? ?/sec 1.00 3.1±0.04µs ? ?/sec in_list_i32 (1024, 0) IN (1, 0) 1.15 2.6±0.02µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_i32 (1024, 0) IN (10, 0) 1.22 2.8±0.04µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_i32 (1024, 0) IN (100, 0) 1.16 2.7±0.04µs ? ?/sec 1.00 2.3±0.02µs ? ?/sec in_list_i32 (1024, 0) IN (3, 0) 1.25 2.9±0.06µs ? ?/sec 1.00 2.3±0.02µs ? ?/sec in_list_i32 (1024, 0.2) IN (1, 0) 1.16 3.6±0.10µs ? ?/sec 1.00 3.1±0.06µs ? ?/sec in_list_i32 (1024, 0.2) IN (10, 0) 1.09 3.4±0.05µs ? ?/sec 1.00 3.2±0.03µs ? ?/sec in_list_i32 (1024, 0.2) IN (100, 0) 1.03 3.2±0.05µs ? ?/sec 1.00 3.1±0.12µs ? ?/sec in_list_i32 (1024, 0.2) IN (3, 0) 1.18 3.6±0.14µs ? ?/sec 1.00 3.1±0.03µs ? ?/sec in_list_utf8(10) (1024, 0) IN (1, 0) 1.71 3.9±0.05µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_utf8(10) (1024, 0) IN (10, 0) 1.74 4.0±0.08µs ? ?/sec 1.00 2.3±0.04µs ? ?/sec in_list_utf8(10) (1024, 0) IN (100, 0) 1.75 4.0±0.05µs ? ?/sec 1.00 2.3±0.02µs ? ?/sec in_list_utf8(10) (1024, 0) IN (3, 0) 1.75 4.0±0.07µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_utf8(10) (1024, 0.2) IN (1, 0) 1.26 4.1±0.04µs ? ?/sec 1.00 3.3±0.05µs ? ?/sec in_list_utf8(10) (1024, 0.2) IN (10, 0) 1.25 4.2±0.07µs ? ?/sec 1.00 3.4±0.03µs ? ?/sec in_list_utf8(10) (1024, 0.2) IN (100, 0) 1.21 4.2±0.08µs ? ?/sec 1.00 3.5±0.06µs ? ?/sec in_list_utf8(10) (1024, 0.2) IN (3, 0) 1.29 4.3±0.11µs ? ?/sec 1.00 3.3±0.03µs ? ?/sec in_list_utf8(20) (1024, 0) IN (1, 0) 1.74 4.0±0.08µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_utf8(20) (1024, 0) IN (10, 0) 1.73 4.0±0.10µs ? ?/sec 1.00 2.3±0.04µs ? ?/sec in_list_utf8(20) (1024, 0) IN (100, 0) 1.74 4.0±0.12µs ? ?/sec 1.00 2.3±0.04µs ? ?/sec in_list_utf8(20) (1024, 0) IN (3, 0) 1.75 4.0±0.08µs ? ?/sec 1.00 2.3±0.05µs ? ?/sec in_list_utf8(20) (1024, 0.2) IN (1, 0) 1.22 4.2±0.06µs ? ?/sec 1.00 3.4±0.05µs ? ?/sec in_list_utf8(20) (1024, 0.2) IN (10, 0) 1.23 4.2±0.06µs ? ?/sec 1.00 3.4±0.04µs ? ?/sec in_list_utf8(20) (1024, 0.2) IN (100, 0) 1.17 4.2±0.05µs ? ?/sec 1.00 3.6±0.03µs ? ?/sec in_list_utf8(20) (1024, 0.2) IN (3, 0) 1.23 4.2±0.12µs ? ?/sec 1.00 3.4±0.06µs ? ?/sec in_list_utf8(5) (1024, 0) IN (1, 0) 1.68 3.9±0.05µs ? ?/sec 1.00 2.3±0.05µs ? ?/sec in_list_utf8(5) (1024, 0) IN (10, 0) 1.78 4.1±0.08µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_utf8(5) (1024, 0) IN (100, 0) 1.76 4.0±0.07µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_utf8(5) (1024, 0) IN (3, 0) 1.76 4.0±0.07µs ? ?/sec 1.00 2.3±0.03µs ? ?/sec in_list_utf8(5) (1024, 0.2) IN (1, 0) 1.27 4.2±0.06µs ? ?/sec 1.00 3.3±0.04µs ? ?/sec in_list_utf8(5) (1024, 0.2) IN (10, 0) 1.26 4.2±0.08µs ? ?/sec 1.00 3.4±0.02µs ? ?/sec in_list_utf8(5) (1024, 0.2) IN (100, 0) 1.25 4.3±0.06µs ? ?/sec 1.00 3.4±0.03µs ? ?/sec in_list_utf8(5) (1024, 0.2) IN (3, 0) 1.34 4.4±0.29µs ? ?/sec 1.00 3.3±0.05µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
