LucaCappelletti94 commented on code in PR #2077:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2077#discussion_r2515134823
##########
src/tokenizer.rs:
##########
@@ -449,29 +449,6 @@ impl Word {
}
}
-#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
-#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub enum Whitespace {
- Space,
- Newline,
- Tab,
- SingleLineComment { comment: String, prefix: String },
- MultiLineComment(String),
-}
Review Comment:
Hi @Viicos, I have nothing against comments - in fact, a PhD student in my
team is working on the #2069 PR for handling them in a more structured manner
in the AST. They just should not exist in the form of whitespace. Could you
kindly expand on your IDE completions note? I am not sure I understood it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
