alamb commented on code in PR #18621:
URL: https://github.com/apache/datafusion/pull/18621#discussion_r2515241872
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -2486,41 +2486,141 @@ mod tests {
#[test]
fn and_test() -> Result<()> {
let cases = vec![
- (false, true, false, false, false, false),
- (false, false, false, true, false, false),
- (false, true, false, true, false, true),
- (false, true, true, true, false, true),
- (false, false, false, false, false, false),
- (true, true, true, true, true, true),
+ (
Review Comment:
😍 -- this is much easier to understand
Maybe we could also add a comment explaining what each field is -- `<arg0>
AND <arg1>` and expected output `<arg0>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
