alamb commented on code in PR #18624:
URL: https://github.com/apache/datafusion/pull/18624#discussion_r2515477598
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -310,11 +310,20 @@ impl DataFrame {
pub fn select_columns(self, columns: &[&str]) -> Result<DataFrame> {
let fields = columns
.iter()
- .flat_map(|name| {
- self.plan
+ .map(|name| {
+ let fields = self
+ .plan
.schema()
- .qualified_fields_with_unqualified_name(name)
+ .qualified_fields_with_unqualified_name(name);
+ if fields.is_empty() {
+ Err(unqualified_field_not_found(name, self.plan.schema()))
+ } else {
+ Ok(fields)
Review Comment:
do we also have to check that we found *all* the fields?
Like what if some fields are found and some are not 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
