pepijnve commented on code in PR #18625:
URL: https://github.com/apache/datafusion/pull/18625#discussion_r2515485979
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -1756,27 +1794,31 @@ impl NullableInterval {
/// Return true if the value is definitely true (and not null).
pub fn is_certainly_true(&self) -> bool {
- match self {
- Self::Null { .. } | Self::MaybeNull { .. } => false,
- Self::NotNull { values } => values == &Interval::CERTAINLY_TRUE,
- }
+ self == &Self::TRUE
Review Comment:
Nope, just simpler and more self explanatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
