pepijnve commented on code in PR #18625:
URL: https://github.com/apache/datafusion/pull/18625#discussion_r2515864935


##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -1738,6 +1738,44 @@ impl From<ScalarValue> for NullableInterval {
 }
 
 impl NullableInterval {
+    /// An interval that only contains 'false'.
+    pub const FALSE: Self = NullableInterval::NotNull {
+        values: Interval::CERTAINLY_FALSE,
+    };
+
+    /// An interval that only contains 'true'.
+    pub const TRUE: Self = NullableInterval::NotNull {
+        values: Interval::CERTAINLY_TRUE,
+    };
+
+    /// An interval that only contains 'unknown' (boolean null).
+    pub const UNKNOWN: Self = NullableInterval::Null {

Review Comment:
   @alamb I was doing some research on 3VL and came across 
https://www.logic.at/multlog/kleene.pdf. If you're not a fan of `unknown`, I'm 
sure you'll love the name/symbol that's used in this paper: `*` 😄
   
   https://logic.dougowings.net/doc/logics/k3.html speaks of 'neither true nor 
false'
   
https://builds.openlogicproject.org/content/many-valued-logic/three-valued-logics/kleene.pdf
 uses both 'undefined' and 'unknown'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to