hsiang-c commented on code in PR #18635:
URL: https://github.com/apache/datafusion/pull/18635#discussion_r2516211075
##########
datafusion/common/src/config.rs:
##########
@@ -606,6 +606,28 @@ config_namespace! {
/// written, it may be necessary to increase this size to avoid errors
from
/// the remote end point.
pub objectstore_writer_buffer_size: usize, default = 10 * 1024 * 1024
+
+ /// Whether to enable ANSI SQL mode.
+ ///
+ /// Currently only used in DataFusion Spark crate
+ ///
+ /// When `enable_ansi_mode` is set to `true`, the query engine
enforces ANSI SQL
+ /// semantics for expressions, casting, and error handling. This
includes:
+ /// - Strict type coercion rules: implicit casts between incompatible
types are disallowed.
+ /// - Standard SQL arithmetic behavior: operations like division by
zero or overflow
+ /// result in runtime errors instead of returning `NULL` or silently
truncating values.
Review Comment:
(nit) In `abs()`, the value that results in overflow is returned as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
