kosiew commented on code in PR #18607:
URL: https://github.com/apache/datafusion/pull/18607#discussion_r2517566399
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -212,6 +213,11 @@ impl FunctionArgs {
}
}
+// Type alias to simplify very complex tuple return types used by helper
+// functions in this module. Using a named alias reduces the type complexity
+// shown in compiler errors and improves readability.
Review Comment:
Removed the comment.
Moving the alias closer to fn `extract_and_prepend_within_group_args`
generated this compiler error
`error[E0658]: inherent associated types are unstable`
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -212,6 +213,11 @@ impl FunctionArgs {
}
}
+// Type alias to simplify very complex tuple return types used by helper
+// functions in this module. Using a named alias reduces the type complexity
+// shown in compiler errors and improves readability.
Review Comment:
On a stable Rust release, this errors is resolved by moving the type alias
outside of the impl block and making it a top-level type alias
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
