rluvaton opened a new issue, #2765:
URL: https://github.com/apache/datafusion-comet/issues/2765
I see there is a trend of removing custom config to enable specific
incompatible (altough I only see 1 PR 😅 )
example:
- #2242 which states
> Remove `COMET_CAST_ALLOW_INCOMPATIBLE` config.
`COMET_EXPR_ALLOW_INCOMPATIBLE` is used instead.
I think this change is not very good as I want to be able to enable only
specific incompatibles that I'm not affected by them.
for example:
Casting from String to Float is marked as incompatible due to:
https://github.com/apache/datafusion-comet/blob/62c988f64faba70648d6c6e120f4daea96bab9c7/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala#L183-L188
But if I know that my data doesn't have problematic input. If I enable that
I enable all casts/other incompatible expressions.
Ideally I would be able to have expression specific incompatibility config
so I can enable them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
