pepijnve opened a new pull request, #18654: URL: https://github.com/apache/datafusion/pull/18654
## Which issue does this PR close? - None, followup to #18625 ## Rationale for this change The discussion in #18625 made it clear that the naming of the truth value intervals would benefit from consistency. After some back and forth we concluded that consistency with the SQL specification seemed like the best idea. This PR renames the boolean `Interval` and `NullableInterval` constants to all be consistent. ## What changes are included in this PR? Mechanical refactoring where the following renames were performed: - `Interval::CERTAINLY_TRUE` -> `Interval::TRUE` - `Interval::CERTAINLY_FALSE` -> `Interval::FALSE` - `Interval::UNCERTAIN` -> `Interval::TRUE_OR_FALSE` - `NullableInterval::UNCERTAIN` -> `NullableInterval::ANY_TRUTH_VALUE` The old constant names have been retained with a deprecation note. ## Are these changes tested? No new code ## Are there any user-facing changes? Yes, the old constants are now marked deprecated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
