martin-g commented on code in PR #18654:
URL: https://github.com/apache/datafusion/pull/18654#discussion_r2523545904
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -610,20 +622,20 @@ impl Interval {
}
// Return UNCERTAIN when intervals don't have concrete boolean
bounds
Review Comment:
```suggestion
// Return TRUE_OR_FALSE when intervals don't have concrete
boolean bounds
```
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
Review Comment:
```suggestion
// An interval with two `Boolean(None)` boundaries is normalised to
`Interval::TRUE_OR_FALSE`.
```
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -585,7 +597,7 @@ impl Interval {
}
// Return UNCERTAIN when intervals don't have concrete boolean
bounds
Review Comment:
```suggestion
// Return TRUE_OR_FALSE when intervals don't have concrete
boolean bounds
```
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -2742,63 +2702,63 @@ mod tests {
Interval::try_new(ScalarValue::Boolean(None),
ScalarValue::Boolean(None))
.unwrap();
- assert_eq!(null_interval, Interval::UNCERTAIN);
+ assert_eq!(null_interval, Interval::TRUE_OR_FALSE);
}
// Asserts that `Interval::UNCERTAIN` represents a set that contains
`true`, `false`, and does
Review Comment:
```suggestion
// Asserts that `Interval::TRUE_OR_FALSE` represents a set that contains
`true`, `false`, and does
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
