timsaucer commented on PR #17994: URL: https://github.com/apache/datafusion/pull/17994#issuecomment-3523531770
I'm sorry I haven't had a chance to review this in detail. One thing we need is an integration test, similar to those in `datafusion/ffi/tests` and their correspond portion in `datafusion/ffi/src/tests`. The reason this is needed is because we need to build a provider in a different library than the one testing it to ensure we can safely cross the FFI boundary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
