mbutrovich commented on code in PR #2768:
URL: https://github.com/apache/datafusion-comet/pull/2768#discussion_r2524106546
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -548,19 +385,27 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
s
}
- case op: LocalTableScanExec =>
- if (CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.get(conf)) {
- operator2Proto(op)
- .map { nativeOp =>
- val cometOp = CometLocalTableScanExec(op, op.rows, op.output)
- CometScanWrapper(nativeOp, cometOp)
+ case op =>
+ // check if this is a fully native operator
+ cometNativeExecHandlers.get(op.getClass) match {
+ case Some(_handler) =>
Review Comment:
_ prefix is usually for unused variables, right? I guess you have a
`handler` below, so this helps disambiguate, but _ still confused me at first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
