rluvaton commented on code in PR #18183:
URL: https://github.com/apache/datafusion/pull/18183#discussion_r2524533582


##########
datafusion/physical-expr/src/expressions/case/mod.rs:
##########
@@ -1954,4 +2018,805 @@ mod tests {
 
         Ok(())
     }
+
+    // Test Lookup evaluation
+
+    enum AssertLookupEvaluation {

Review Comment:
   also this tests allow more fine control on the plan, and the tests are still 
built in integration like way - the test implementation build the plan like the 
end user, there is only single assert here that check that this implementation 
is used and in can easily be wrapped inside an `if` to avoid asserting that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to