2010YOUY01 commented on code in PR #18577:
URL: https://github.com/apache/datafusion/pull/18577#discussion_r2525647959
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -129,6 +130,17 @@ impl AsyncFileReader for ParquetFileReader {
}
}
+impl Drop for ParquetFileReader {
+ fn drop(&mut self) {
+ self.file_metrics
+ .scan_efficiency_ratio
+ .add_part(self.file_metrics.bytes_scanned.value());
+ self.file_metrics
+ .scan_efficiency_ratio
+ .add_total(self.partitioned_file.object_meta.size as usize);
Review Comment:
Perhaps in
https://github.com/apache/parquet-testing/tree/107b36603e051aee26bd93e04b871034f6c756c0,
we can find a existing parquet test file, with multiple row groups, and apply
a filter that can prune out some row groups.
However, we can proceed as is. Since it's just a metric, the impact is
minimal even if it misbehaves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
