manuzhang commented on code in PR #2772:
URL: https://github.com/apache/datafusion-comet/pull/2772#discussion_r2525693869
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -163,6 +162,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
classOf[StringRPad] -> CometStringRPad,
classOf[StringLPad] -> CometStringLPad,
classOf[StringSpace] -> CometScalarFunction("string_space"),
+ classOf[StringSplit] -> CometScalarFunction("string_to_array"),
Review Comment:
I don't think `string_to_array` is the same as Spark's
[split](https://spark.apache.org/docs/latest/sql-ref-functions-builtin.html#string-functions)
function | description
-- | --
string_to_array(array, delimiter, null_string) | Splits a string based on a
delimiter and returns an array of parts. Any parts matching the optional
null_string will be replaced with NULL. `string_to_array('abc#def#ghi', '#', '
') -> ['abc', 'def', 'ghi']`
split(str, regex, limit) | Splits `str` around occurrences that match
`regex` and returns an array with a length of at most `limit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
