alamb commented on code in PR #18678:
URL: https://github.com/apache/datafusion/pull/18678#discussion_r2529850335
##########
datafusion/optimizer/src/optimize_unions.rs:
##########
@@ -26,19 +26,25 @@ use itertools::Itertools;
use std::sync::Arc;
#[derive(Default, Debug)]
-/// An optimization rule that replaces nested unions with a single union.
-pub struct EliminateNestedUnion;
+/// An optimization rule that
+/// 1. replaces nested unions with a single union.
+/// 2. removes unions with a single input.
+pub struct OptimizeUnions;
-impl EliminateNestedUnion {
+// Backwards compatibility name
+#[deprecated(since = "52.0.0", note = "Please use OptimizeUnions instead")]
+pub type EliminateNestedUnion = OptimizeUnions;
Review Comment:
That is a good point -- I will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
