andygrove commented on code in PR #1338: URL: https://github.com/apache/datafusion-ballista/pull/1338#discussion_r2530065559
########## python/python/ballista/extension.py: ########## @@ -0,0 +1,114 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from datafusion import SessionContext +from datafusion import DataFrame +from ._internal_ballista import PyBallistaRemoteExecutor + + +class RedefiningMeta(type): + def __new__(cls, name, bases, attrs): + def __wrap_dataframe_result(func): + def method_wrapper(*args, **kwargs): + address = args[0].address + session_id = args[0].session_id + df = func(*args, **kwargs) + return DistributedDataFrame(df, session_id, address) + + return method_wrapper + + for base_name, base_value in bases[0].__dict__.items(): + # + # could we not use 'DataFrame' as a string here? + # + if ( + callable(base_value) + and not base_name.startswith("__") + and base_value.__annotations__.get("return") == "DataFrame" + ): + # + # functions which return DataFrame are redefined + # to return DistributedDataFrame + # + attrs[base_name] = __wrap_dataframe_result(base_value) + + return super().__new__(cls, name, bases, attrs) + + +# main difference between this class and DataFrame is that +# operations which would execute logical plan will +# serialize it and invoke ballista client to execute it +# +# this class keeps reference to remote ballista + + +class DistributedDataFrame(DataFrame, metaclass=RedefiningMeta): + def __init__(self, df: DataFrame, session_id: str, address: str): + super().__init__(df.df) + self.address = address + self.session_id = session_id + + def _to_internal_df(self): + blob_plan = self.logical_plan().to_proto() + df = PyBallistaRemoteExecutor.create_data_frame( + blob_plan, self.address, self.session_id + ) + return df Review Comment: +1 for replacing the physical planning/optimizer path to use Ballista instead of DataFusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
