zhuqi-lucas commented on PR #18729: URL: https://github.com/apache/datafusion/pull/18729#issuecomment-3537459165
> LGTM, thank you. > > I noticed it only benchmarked the case that both needle and haystack are `ScalarValue`, perhaps we can also benchmark `Array` cases in the future. Thank you @2010YOUY01 for review, i agree we can add `Array` cases as follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
