adriangb commented on code in PR #18799:
URL: https://github.com/apache/datafusion/pull/18799#discussion_r2540890696
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -57,6 +57,8 @@ struct Inner {
/// This is used for [`PhysicalExpr::snapshot_generation`] to have a cheap
check for changes.
generation: u64,
expr: Arc<dyn PhysicalExpr>,
+ /// Flag indicating whether all updates have been received and the filter
is complete.
+ is_complete: bool,
Review Comment:
I like this idea! I had previously prototyped this to notify listeners any
time `update` is called. Maybe we need something like "notify and include a
Boolean indicating if this is a finalized update or not"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
