shivbhatia10 commented on code in PR #18819:
URL: https://github.com/apache/datafusion/pull/18819#discussion_r2542399592


##########
datafusion/physical-expr/src/async_scalar_function.rs:
##########
@@ -192,10 +192,18 @@ impl AsyncFuncExpr {
             );
         }
 
-        let datas = ColumnarValue::values_to_arrays(&result_batches)?

Review Comment:
   `ColumnarValue::values_to_arrays` requires that each batch has the same 
length, but this is not necessarily the case for our batches here. If the ideal 
batch size doesn't evenly divide the total number of rows we'll get one batch 
at the end with a different length.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to