pepijnve commented on code in PR #17813:
URL: https://github.com/apache/datafusion/pull/17813#discussion_r2545900901
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -282,14 +284,80 @@ impl ExprSchemable for Expr {
Expr::OuterReferenceColumn(field, _) => Ok(field.is_nullable()),
Expr::Literal(value, _) => Ok(value.is_null()),
Expr::Case(case) => {
Review Comment:
That's absolutely correct. Performance overhead concerns were the main
reason I had initially avoided rewriting the expression and instead tried to do
the rewrite indirectly. Rather than rewriting using a `NullableInterval::Null`
guarantee, I was checking this using a callback function.
It's feasible, but non-trivial to cache this field. What would you use as
storage location?
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -282,14 +284,80 @@ impl ExprSchemable for Expr {
Expr::OuterReferenceColumn(field, _) => Ok(field.is_nullable()),
Expr::Literal(value, _) => Ok(value.is_null()),
Expr::Case(case) => {
Review Comment:
That's absolutely correct. Performance overhead concerns were the main
reason I had initially avoided rewriting the expression and instead tried to do
the rewrite indirectly. Rather than rewriting using a `NullableInterval::Null`
guarantee, I was checking this using a callback function.
It's probably feasible, but non-trivial to cache this result. What would you
use as storage location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
