asolimando commented on code in PR #18842:
URL: https://github.com/apache/datafusion/pull/18842#discussion_r2546632345
##########
datafusion/substrait/src/logical_plan/consumer/rel/read_rel.rs:
##########
@@ -121,57 +121,50 @@ pub async fn from_read_rel(
}));
}
+ // Check for produce_one_row pattern in both old (values) and new
(expressions) formats.
+ // A VirtualTable with exactly one row containing only
empty/default fields represents
+ // an EmptyRelation with produce_one_row=true. This pattern is
used for queries without
Review Comment:
In Oracle the "one row (dummy) table" is called the ["dual
table"](https://en.wikipedia.org/wiki/DUAL_table), by checking the "In other
database systems" section it seems to be quite a well-known name for that
concept.
I am not suggesting to necessarily adopt this name here, but maybe a
reference to it in the comments could be good for people with a DB background,
but not necessarily familiar with Datafusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
