alamb commented on code in PR #18820: URL: https://github.com/apache/datafusion/pull/18820#discussion_r2547637373
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -710,13 +710,13 @@ select query TTT select arrow_typeof(column1), arrow_typeof(column2), arrow_typeof(column3) from arrays; ---- -List(nullable List(nullable Int64)) List(nullable Float64) List(nullable Utf8) Review Comment: Previously the DataType parsing code did not handle this syntax (it only supported `List(Float64)`). We have now made the display and parsing consistent, see https://github.com/apache/arrow-rs/pull/8649#issuecomment-3559845773 for background and details ########## datafusion-cli/src/main.rs: ########## @@ -592,9 +592,9 @@ mod tests { +-----------------------------------+-----------------+---------------------+------+------------------+ | filename | file_size_bytes | metadata_size_bytes | hits | extra | +-----------------------------------+-----------------+---------------------+------+------------------+ - | alltypes_plain.parquet | 1851 | 6957 | 2 | page_index=false | - | alltypes_tiny_pages.parquet | 454233 | 267014 | 2 | page_index=true | - | lz4_raw_compressed_larger.parquet | 380836 | 996 | 2 | page_index=false | + | alltypes_plain.parquet | 1851 | 8882 | 2 | page_index=false | Review Comment: Actually I looked into it more and I think the size growth is a bug. See - https://github.com/apache/arrow-rs/issues/8897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
