Jefffrey commented on code in PR #18828:
URL: https://github.com/apache/datafusion/pull/18828#discussion_r2548333626
##########
datafusion/spark/src/function/math/abs.rs:
##########
@@ -262,12 +313,102 @@ mod tests {
eval_legacy_mode!(Float64, -0.0f64, 0.0f64);
}
+ macro_rules! eval_ansi_mode {
Review Comment:
I can't help but feel a lot of this test code could be compacted in some
way, as it seems quite verbose; haven't had time to properly check this however
so don't really have a suggestion myself 🤔
##########
datafusion/sqllogictest/src/test_context.rs:
##########
@@ -78,7 +78,8 @@ impl TestContext {
pub async fn try_new_for_test_file(relative_path: &Path) -> Option<Self> {
let config = SessionConfig::new()
// hardcode target partitions so plans are deterministic
- .with_target_partitions(4);
+ .with_target_partitions(4)
+ .with_enable_ansi_mode(true);
Review Comment:
Can we just set it like so instead?
https://github.com/apache/datafusion/blob/f1ecaccd183367086ecb5b7736d93b3aba109e01/datafusion/sqllogictest/test_files/cte.slt#L45-L47
Instead of doing it globally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
