Jefffrey commented on PR #18763: URL: https://github.com/apache/datafusion/pull/18763#issuecomment-3561074665
I'll try review this when I have time; but it would be nice if we have some benchmarks to verify this doesn't regress performance. Off the top of my head we'd need a benchmark for count(distinct) where type is not float (e.g. int64), one where it is float, and a benchmark for median or percentile_cont. Reason being, in current main: - count(distinct) non-float -> uses `PrimitiveDistinctCountAccumulator` - count(distinct) float -> uses `FloatDistinctCountAccumulator` - percentile_cont/median -> uses `GenericDistinctBuffer` (which I believe `FloatDistinctCountAccumulator` uses too?) So they should be a representative sample of affected functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
