Standing-Man commented on code in PR #18768:
URL: https://github.com/apache/datafusion/pull/18768#discussion_r2548433289
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -295,7 +295,7 @@ impl DigestAlgorithm {
pub fn digest_utf8_array_impl<'a, StringArrType>(
self,
- input_value: StringArrType,
+ input_value: &StringArrType,
Review Comment:
Yes, but Clippy warns that `input_value` is not consumed in the function
body, suggesting we take a reference instead. Therefore, the parameter of
`digest_utf8_array_impl` needs to be a double reference (&&).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
