alchemist51 commented on code in PR #18855:
URL: https://github.com/apache/datafusion/pull/18855#discussion_r2548494519
##########
datafusion/execution/src/cache/cache_manager.rs:
##########
@@ -228,13 +276,30 @@ impl CacheManagerConfig {
}
/// Set the cache for listing files.
- ///
+ ///
/// Default is `None` (disabled).
- pub fn with_list_files_cache(mut self, cache: Option<ListFilesCache>) ->
Self {
+ pub fn with_list_files_cache(
+ mut self,
+ cache: Option<Arc<dyn ListFilesCache>>,
+ ) -> Self {
self.list_files_cache = cache;
self
}
+ pub fn with_list_files_cache_limit(mut self, limit: usize) -> Self {
+ self.list_files_cache_limit = limit;
+ self
+ }
+
+ pub fn with_list_files_cache_ttl(mut self, ttl: Duration) -> Self {
+ self.list_files_cache_ttl = ttl;
+ if ttl.is_zero() {
Review Comment:
Why are we setting it to None in case of no TTL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
