2010YOUY01 commented on code in PR #18864:
URL: https://github.com/apache/datafusion/pull/18864#discussion_r2548881303
##########
datafusion/physical-plan/src/aggregates/no_grouping.rs:
##########
@@ -68,14 +68,14 @@ impl AggregateStream {
/// Create a new AggregateStream
pub fn new(
Review Comment:
this is a `pub(crate)`
##########
datafusion/physical-plan/src/aggregates/topk_stream.rs:
##########
@@ -54,13 +54,13 @@ pub struct GroupedTopKAggregateStream {
impl GroupedTopKAggregateStream {
pub fn new(
Review Comment:
This API is private inside `physical-plan/aggregates` module
(do we have a convenient way to check the external visibility? Now I'm
manually traversing to its parents to verify)
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -445,7 +445,7 @@ impl GroupedHashAggregateStream {
/// Create a new GroupedHashAggregateStream
pub fn new(
Review Comment:
This is a `pub(crate)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
