Jefffrey commented on code in PR #18877:
URL: https://github.com/apache/datafusion/pull/18877#discussion_r2551843611
##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -382,49 +382,32 @@ where
}
}
-#[expect(clippy::needless_pass_by_value)]
Review Comment:
I wanted to fix this lint, then realised could do a wider refactor to
eliminate this function and simplify the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
