Jefffrey commented on PR #18137: URL: https://github.com/apache/datafusion/pull/18137#issuecomment-3565499853
> > > I was actually thinking we need to delegate the execution to array_concat if input is arrays rather than implementing it again > > > > > > @EeshanBembi did you look into the feasibility of this suggestion? > > Hey @Jefffrey , I implemented delegating the execution to use array_concat! I'm still having trouble seeing how this is happening in the PR 🤔 From what I can see, the code to handle concat of arrays is still entirely new (or perhaps copied as is). In my mind I was thinking something along the lines of using `simplify` to convert the function to the array concat version, instead of duplicating that code here. But I haven't got hands on with this yet so perhaps there is some sort of limitation that prevents this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
