dqkqd commented on issue #18458: URL: https://github.com/apache/datafusion/issues/18458#issuecomment-3566077618
I was looking into this. For `ListArray` and `LargListArray` inputs, I think we have to copy child arrays to construct the return array, regardless of whether they are contiguous. A solution is to always return `ListViewArray` / `LargListViewArray` for `array_slice`, so we can avoid copying data when the range is contiguous. This also line up with my understanding that slicing is just a view, not a copy. Should I go with this approach? @Jefffrey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
