dqkqd commented on issue #18458:
URL: https://github.com/apache/datafusion/issues/18458#issuecomment-3567260813

   > I don't know if it is preferable to always return view types or not 🤔
   
   I looked up and found that a similar idea has been adoped for `StringView` 
in #10918. 
   
   I also [played with it a 
bit](https://github.com/dqkqd/datafusion/commit/4126e1b56ac91f2e95e5ebb608019c1f597772b2),
 it was 6 times faster with the micro-benchmark from #18879 
   
   ```
   Gnuplot not found, using plotters backend
   array_slice: input List(nullable Int64), array args, no stride
                           time:   [14.794 ms 14.873 ms 14.961 ms]
                           change: [−84.683% −84.603% −84.510%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) high mild
     1 (1.00%) high severe
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to