alamb commented on code in PR #18688:
URL: https://github.com/apache/datafusion/pull/18688#discussion_r2554121314
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -2338,6 +2338,29 @@ async fn cache_test() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn cache_producer_test() -> Result<()> {
+ let df = test_table_with_cache_producer()
+ .await?
+ .select_columns(&["c2", "c3"])?
+ .limit(0, Some(1))?
+ .with_column("sum", cast(col("c2") + col("c3"), DataType::Int64))?;
+
+ let cached_df = df.clone().cache().await?;
+
+ assert_snapshot!(
+ cached_df.clone().into_optimized_plan().unwrap(),
+ @r###"
+ CacheNode
+ Projection: aggregate_test_100.c2, aggregate_test_100.c3,
CAST(CAST(aggregate_test_100.c2 AS Int64) + CAST(aggregate_test_100.c3 AS
Int64) AS Int64) AS sum
+ Projection: aggregate_test_100.c2, aggregate_test_100.c3
+ Limit: skip=0, fetch=1
+ TableScan: aggregate_test_100, fetch=1
+ "###
+ );
Review Comment:
Thanks -- can you please file a ticket to track this work?
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -2047,6 +2078,19 @@ pub(crate) struct PreparedPlan {
pub(crate) plan: Arc<LogicalPlan>,
}
+/// A [`CacheFactory`] can be registered via [`SessionState`]
Review Comment:
There are many things that might be cached in the context of DataFusion
(e.g. parquet metadata, etc)
It would be nice to mention in these comments that the API is used for
`DataFrame::cache` to help users find what thtye are looking for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
